Bug 48662

Summary: Results for media test controls-drag-timebar.html are needlessly platform specific
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch aroben: review+

Description Eric Carlson 2010-10-29 12:33:31 PDT
controls-drag-timebar.html tests that dragging on a media controller thumb changes a movie's time. The current test results are platform specific because they include the name of the movie used for the test and the movie's current time when the 'seeked' event is fired. This information is not needed in the log file, we only need to ensure that seeking happens in response to mouse events.

The test should be cleaned up and all platform specific results should be deleted.
Comment 1 Eric Carlson 2010-10-29 13:16:41 PDT
Created attachment 72378 [details]
Proposed patch
Comment 2 Adam Roben (:aroben) 2010-10-29 13:46:16 PDT
Comment on attachment 72378 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72378&action=review

> LayoutTests/media/controls-drag-timebar-expected.txt:13
> +Dragging mouse -14 pixels left

That should be "14 pixels left".
Comment 3 Eric Carlson 2010-10-29 14:19:35 PDT
(In reply to comment #2)
> (From update of attachment 72378 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72378&action=review
> 
> > LayoutTests/media/controls-drag-timebar-expected.txt:13
> > +Dragging mouse -14 pixels left
> 
> That should be "14 pixels left".

Good point, thanks!
Comment 4 Eric Carlson 2010-10-29 14:20:01 PDT
http://trac.webkit.org/changeset/70926
Comment 5 WebKit Review Bot 2010-10-29 15:34:18 PDT
http://trac.webkit.org/changeset/70926 might have broken Leopard Intel Release (Tests) and Leopard Intel Debug (Tests)
The following tests are not passing:
media/controls-drag-timebar.html
Comment 6 Eric Carlson 2010-10-29 15:44:39 PDT
Test modified in http://trac.webkit.org/changeset/70940.