WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
48662
Results for media test controls-drag-timebar.html are needlessly platform specific
https://bugs.webkit.org/show_bug.cgi?id=48662
Summary
Results for media test controls-drag-timebar.html are needlessly platform spe...
Eric Carlson
Reported
2010-10-29 12:33:31 PDT
controls-drag-timebar.html tests that dragging on a media controller thumb changes a movie's time. The current test results are platform specific because they include the name of the movie used for the test and the movie's current time when the 'seeked' event is fired. This information is not needed in the log file, we only need to ensure that seeking happens in response to mouse events. The test should be cleaned up and all platform specific results should be deleted.
Attachments
Proposed patch
(10.58 KB, patch)
2010-10-29 13:16 PDT
,
Eric Carlson
aroben
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Carlson
Comment 1
2010-10-29 13:16:41 PDT
Created
attachment 72378
[details]
Proposed patch
Adam Roben (:aroben)
Comment 2
2010-10-29 13:46:16 PDT
Comment on
attachment 72378
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=72378&action=review
> LayoutTests/media/controls-drag-timebar-expected.txt:13 > +Dragging mouse -14 pixels left
That should be "14 pixels left".
Eric Carlson
Comment 3
2010-10-29 14:19:35 PDT
(In reply to
comment #2
)
> (From update of
attachment 72378
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=72378&action=review
> > > LayoutTests/media/controls-drag-timebar-expected.txt:13 > > +Dragging mouse -14 pixels left > > That should be "14 pixels left".
Good point, thanks!
Eric Carlson
Comment 4
2010-10-29 14:20:01 PDT
http://trac.webkit.org/changeset/70926
WebKit Review Bot
Comment 5
2010-10-29 15:34:18 PDT
http://trac.webkit.org/changeset/70926
might have broken Leopard Intel Release (Tests) and Leopard Intel Debug (Tests) The following tests are not passing: media/controls-drag-timebar.html
Eric Carlson
Comment 6
2010-10-29 15:44:39 PDT
Test modified in
http://trac.webkit.org/changeset/70940
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug