Bug 48657

Summary: [chromium] add debug logging to help diagnose flakiness dashboard issues
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch tony: review+

Description Ojan Vafai 2010-10-29 12:14:42 PDT
[chromium] add debug logging to help diagnose flakiness dashboard issues
Comment 1 Ojan Vafai 2010-10-29 12:16:01 PDT
Created attachment 72365 [details]
Patch
Comment 2 Tony Chang 2010-10-29 12:19:54 PDT
Comment on attachment 72365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72365&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:966
>          files = [(file, os.path.join(self._options.results_directory, file))
>              for file in json_files]

Using a tuple here instead of a struct-like class makes me sad.
Comment 3 Ojan Vafai 2010-10-29 13:58:26 PDT
This seems to be resolved. Didn't end up committing.
Comment 4 Ojan Vafai 2010-10-29 14:02:41 PDT
Sigh. nm. Still need this. Will commit shortly.
Comment 5 Ojan Vafai 2010-10-29 14:06:26 PDT
Committed r70924: <http://trac.webkit.org/changeset/70924>
Comment 6 WebKit Review Bot 2010-10-29 15:34:08 PDT
http://trac.webkit.org/changeset/70924 might have broken Leopard Intel Release (Tests) and Leopard Intel Debug (Tests)
The following tests are not passing:
media/controls-drag-timebar.html