Bug 48647

Summary: [Chromium] fast/loader/stateobjects/state-api-on-detached-frame-crash.html does not pass on Chromium
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: Tools / TestsAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Mihai Parparita 2010-10-29 10:45:04 PDT
[Chromium] fast/loader/stateobjects/state-api-on-detached-frame-crash.html does not pass on Chromium
Comment 1 Mihai Parparita 2010-10-29 10:46:26 PDT
Created attachment 72348 [details]
Patch
Comment 2 Mihai Parparita 2010-10-29 10:47:33 PDT
Any of you mind reviewing?
Comment 3 Tony Chang 2010-10-29 10:50:09 PDT
Comment on attachment 72348 [details]
Patch

It would be nice to add some text to the test describing what is being tested, but either way, this change seems fine.
Comment 4 Mihai Parparita 2010-10-29 10:55:49 PDT
(In reply to comment #3)
> (From update of attachment 72348 [details])
> It would be nice to add some text to the test describing what is being tested, but either way, this change seems fine.

True. It used to have a description before http://trac.webkit.org/changeset/53672/trunk/LayoutTests/fast/loader/stateobjects/state-api-on-detached-frame-crash.html, I'll add it back.
Comment 5 Mihai Parparita 2010-10-29 10:59:38 PDT
Created attachment 72350 [details]
Patch
Comment 6 WebKit Commit Bot 2010-10-29 12:00:56 PDT
Comment on attachment 72350 [details]
Patch

Clearing flags on attachment: 72350

Committed r70913: <http://trac.webkit.org/changeset/70913>
Comment 7 WebKit Commit Bot 2010-10-29 12:01:02 PDT
All reviewed patches have been landed.  Closing bug.