Bug 48647 - [Chromium] fast/loader/stateobjects/state-api-on-detached-frame-crash.html does not pass on Chromium
Summary: [Chromium] fast/loader/stateobjects/state-api-on-detached-frame-crash.html do...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mihai Parparita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-29 10:45 PDT by Mihai Parparita
Modified: 2010-10-29 12:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2010-10-29 10:46 PDT, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Patch (3.54 KB, patch)
2010-10-29 10:59 PDT, Mihai Parparita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mihai Parparita 2010-10-29 10:45:04 PDT 
[Chromium] fast/loader/stateobjects/state-api-on-detached-frame-crash.html does not pass on Chromium
Comment 1 Mihai Parparita 2010-10-29 10:46:26 PDT 
Created attachment 72348 [details]
Patch
Comment 2 Mihai Parparita 2010-10-29 10:47:33 PDT 
Any of you mind reviewing?
Comment 3 Tony Chang 2010-10-29 10:50:09 PDT 
Comment on attachment 72348 [details]
Patch

It would be nice to add some text to the test describing what is being tested, but either way, this change seems fine.
Comment 4 Mihai Parparita 2010-10-29 10:55:49 PDT 
(In reply to comment #3)
> (From update of attachment 72348 [details])
> It would be nice to add some text to the test describing what is being tested, but either way, this change seems fine.

True. It used to have a description before http://trac.webkit.org/changeset/53672/trunk/LayoutTests/fast/loader/stateobjects/state-api-on-detached-frame-crash.html, I'll add it back.
Comment 5 Mihai Parparita 2010-10-29 10:59:38 PDT 
Created attachment 72350 [details]
Patch
Comment 6 WebKit Commit Bot 2010-10-29 12:00:56 PDT 
Comment on attachment 72350 [details]
Patch

Clearing flags on attachment: 72350

Committed r70913: <http://trac.webkit.org/changeset/70913>
Comment 7 WebKit Commit Bot 2010-10-29 12:01:02 PDT 
All reviewed patches have been landed.  Closing bug.