| Summary: | Convert SVGAnimatedEnumeration/Integer to the new SVGAnimatedPropertyTearOff concept | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||
| Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric, mdelaney7, zimmermann | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 47905 | ||||||||
| Attachments: |
|
||||||||
|
Description
Nikolas Zimmermann
2010-10-29 03:30:01 PDT
Created attachment 72312 [details]
Patch
My local build is not yet done, I only did the mechanics. But as EWS is not busy right now, I'll keep it busy :-)
Comment on attachment 72312 [details]
Patch
r=me
Attachment 72312 [details] did not build on mac: Build output: http://queues.webkit.org/results/4870031 Comment on attachment 72312 [details]
Patch
It only builds on mac after touching CodeGeneratorObjC.pm, dependency tracking is obviously broken. If I only modfiy CodeGenerator.pm, the objc bindings are not regenerated, only the js bindings :/
I'll need to add whitespace to CodeGeneratorObjC.pm, to fix the build.
Found a local regression though, need to investigate first, clearing Dirks r+ for the meanwhile.
Created attachment 72328 [details]
Patch v2
Fixed regressions, while cleaning up the code, yay :-)
Comment on attachment 72328 [details]
Patch v2
Good catch! r=me
Please file a bug about the broken dependency tracking so we can get it fixed. (In reply to comment #8) > Please file a bug about the broken dependency tracking so we can get it fixed. Yeah, thanks for reminding me, I filed 48641. |