Bug 48587

Summary: Make ruby work with vertical text.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch
none
Patch simon.fraser: review+

Dave Hyatt
Reported 2010-10-28 16:38:49 PDT
Make ruby work with vertical text.
Attachments
Patch (148.27 KB, patch)
2010-11-08 14:08 PST, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (150.78 KB, patch)
2010-11-08 14:09 PST, Dave Hyatt 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adele Peterson
Comment 1 2010-10-29 15:11:22 PDT
<rdar://problem/8612027>
Dave Hyatt
Comment 2 2010-11-08 14:08:05 PST
Created attachment 73278 [details] Patch
Dave Hyatt
Comment 3 2010-11-08 14:09:03 PST
Created attachment 73279 [details] Patch
Dave Hyatt
Comment 4 2010-11-08 14:21:56 PST
Fixed in r71572.
Csaba Osztrogonác
Comment 5 2010-11-08 14:52:56 PST
This patch is incorrect, and it broke Qt minimal build, because you should use isRubyRun in #if ENABLE(RUBY) block. Could you fix it?
Csaba Osztrogonác
Comment 6 2010-11-08 15:17:02 PST
Fixed in http://trac.webkit.org/changeset/71579 , thx Dave.
Note You need to log in before you can comment on or make changes to this bug.