Bug 48587 - Make ruby work with vertical text.
Summary: Make ruby work with vertical text.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords: InRadar
Depends on:
Blocks: 46123
  Show dependency treegraph
 
Reported: 2010-10-28 16:38 PDT by Dave Hyatt
Modified: 2010-11-08 15:17 PST (History)
1 user (show)

See Also:


Attachments
Patch (148.27 KB, patch)
2010-11-08 14:08 PST, Dave Hyatt
no flags Details | Formatted Diff | Diff
Patch (150.78 KB, patch)
2010-11-08 14:09 PST, Dave Hyatt
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-10-28 16:38:49 PDT
Make ruby work with vertical text.
Comment 1 Adele Peterson 2010-10-29 15:11:22 PDT
<rdar://problem/8612027>
Comment 2 Dave Hyatt 2010-11-08 14:08:05 PST
Created attachment 73278 [details]
Patch
Comment 3 Dave Hyatt 2010-11-08 14:09:03 PST
Created attachment 73279 [details]
Patch
Comment 4 Dave Hyatt 2010-11-08 14:21:56 PST
Fixed in r71572.
Comment 5 Csaba Osztrogonác 2010-11-08 14:52:56 PST
This patch is incorrect, and it broke Qt minimal build, 
because you should use isRubyRun in #if ENABLE(RUBY) block.
Could you fix it?
Comment 6 Csaba Osztrogonác 2010-11-08 15:17:02 PST
Fixed in http://trac.webkit.org/changeset/71579 , thx Dave.