Bug 48574

Summary: Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
Product: WebKit Reporter: Darin Adler <darin>
Component: HistoryAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch sam: review+

Darin Adler
Reported 2010-10-28 16:19:56 PDT
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
Attachments
Patch (31.88 KB, patch)
2010-10-28 16:24 PDT, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2010-10-28 16:24:19 PDT
Created attachment 72254 [details] Patch
WebKit Review Bot
Comment 2 2010-10-28 16:26:38 PDT
Attachment 72254 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/win/WebBackForwardList.h:37: Code inside a namespace should not be indented. [whitespace/indent] [4] WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebhistory.cpp" WebKit/gtk/webkit/webkitwebbackforwardlist.cpp:30: Alphabetical sorting problem. [build/include_order] [4] WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebhistory_p.h" WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp" Total errors found: 2 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2010-10-29 14:38:33 PDT
Committed r70931: <http://trac.webkit.org/changeset/70931>
Note You need to log in before you can comment on or make changes to this bug.