Bug 48573

Summary: Include stddef.h unconditionally in Assertions.h
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch none

Kwang Yul Seo
Reported 2010-10-28 16:13:16 PDT
Because OBJECT_OFFSETOF macro in StdLibExtras.h uses ptrdiff_t, we must include stddef.h. <wtf/Assertions.h> indirectly includes stddef.h in many ports, but this is not true for Brew MP port.
Attachments
Patch (1.16 KB, patch)
2010-10-28 16:21 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (974 bytes, patch)
2010-10-28 16:48 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-10-28 16:21:33 PDT
Created attachment 72253 [details] Patch
Darin Adler
Comment 2 2010-10-28 16:27:06 PDT
Comment on attachment 72253 [details] Patch I think a better fix would be to change Assertions.h to include <stddef.h> unconditionally. I don’t see any reason to have that include be MSVC-only.
Kwang Yul Seo
Comment 3 2010-10-28 16:48:01 PDT
Created attachment 72258 [details] Patch
WebKit Commit Bot
Comment 4 2010-10-28 17:43:55 PDT
Comment on attachment 72258 [details] Patch Clearing flags on attachment: 72258 Committed r70829: <http://trac.webkit.org/changeset/70829>
WebKit Commit Bot
Comment 5 2010-10-28 17:44:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.