Bug 48573

Summary: Include stddef.h unconditionally in Assertions.h
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Patch none

Description Kwang Yul Seo 2010-10-28 16:13:16 PDT
Because OBJECT_OFFSETOF macro in StdLibExtras.h uses ptrdiff_t, we must include stddef.h. <wtf/Assertions.h> indirectly includes stddef.h in many ports, but this is not true for Brew MP port.
Comment 1 Kwang Yul Seo 2010-10-28 16:21:33 PDT
Created attachment 72253 [details]
Patch
Comment 2 Darin Adler 2010-10-28 16:27:06 PDT
Comment on attachment 72253 [details]
Patch

I think a better fix would be to change Assertions.h to include <stddef.h> unconditionally. I don’t see any reason to have that include be MSVC-only.
Comment 3 Kwang Yul Seo 2010-10-28 16:48:01 PDT
Created attachment 72258 [details]
Patch
Comment 4 WebKit Commit Bot 2010-10-28 17:43:55 PDT
Comment on attachment 72258 [details]
Patch

Clearing flags on attachment: 72258

Committed r70829: <http://trac.webkit.org/changeset/70829>
Comment 5 WebKit Commit Bot 2010-10-28 17:44:00 PDT
All reviewed patches have been landed.  Closing bug.