Bug 48573 - Include stddef.h unconditionally in Assertions.h
Summary: Include stddef.h unconditionally in Assertions.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-10-28 16:13 PDT by Kwang Yul Seo
Modified: 2010-10-28 17:44 PDT (History)
2 users (show)

See Also:

Patch (1.16 KB, patch)
2010-10-28 16:21 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff
Patch (974 bytes, patch)
2010-10-28 16:48 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-10-28 16:13:16 PDT
Because OBJECT_OFFSETOF macro in StdLibExtras.h uses ptrdiff_t, we must include stddef.h. <wtf/Assertions.h> indirectly includes stddef.h in many ports, but this is not true for Brew MP port.
Comment 1 Kwang Yul Seo 2010-10-28 16:21:33 PDT
Created attachment 72253 [details]
Comment 2 Darin Adler 2010-10-28 16:27:06 PDT
Comment on attachment 72253 [details]

I think a better fix would be to change Assertions.h to include <stddef.h> unconditionally. I don’t see any reason to have that include be MSVC-only.
Comment 3 Kwang Yul Seo 2010-10-28 16:48:01 PDT
Created attachment 72258 [details]
Comment 4 WebKit Commit Bot 2010-10-28 17:43:55 PDT
Comment on attachment 72258 [details]

Clearing flags on attachment: 72258

Committed r70829: <http://trac.webkit.org/changeset/70829>
Comment 5 WebKit Commit Bot 2010-10-28 17:44:00 PDT
All reviewed patches have been landed.  Closing bug.