Bug 48567

Summary: webkit-patch upload calls changed_files more often than it should
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dbates, eric, ojan, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2010-10-28 14:42:31 PDT
webkit-patch upload calls changed_files more often than it should
Attachments
Patch (7.92 KB, patch)
2010-10-28 15:21 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-10-28 15:21:35 PDT
Created attachment 72243 [details] Patch
Adam Barth
Comment 2 2010-10-28 15:42:30 PDT
Comment on attachment 72243 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72243&action=review > WebKitTools/Scripts/webkitpy/tool/commands/upload.py:157 > - bug_id = tool.checkout().bug_id_for_this_commit(options.git_commit) > + changed_files = self._tool.scm().changed_files(options.git_commit) > + state["changed_files"] = changed_files > + bug_id = tool.checkout().bug_id_for_this_commit(options.git_commit, changed_files) Its lame that you need to do this manually. The steps have a slick way of doing this automatically.
WebKit Commit Bot
Comment 3 2010-10-28 16:01:57 PDT
Comment on attachment 72243 [details] Patch Clearing flags on attachment: 72243 Committed r70820: <http://trac.webkit.org/changeset/70820>
WebKit Commit Bot
Comment 4 2010-10-28 16:02:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.