Bug 48567

Summary: webkit-patch upload calls changed_files more often than it should
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dbates, eric, ojan, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Eric Seidel (no email) 2010-10-28 14:42:31 PDT
webkit-patch upload calls changed_files more often than it should
Comment 1 Eric Seidel (no email) 2010-10-28 15:21:35 PDT
Created attachment 72243 [details]
Patch
Comment 2 Adam Barth 2010-10-28 15:42:30 PDT
Comment on attachment 72243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72243&action=review

> WebKitTools/Scripts/webkitpy/tool/commands/upload.py:157
> -            bug_id = tool.checkout().bug_id_for_this_commit(options.git_commit)
> +            changed_files = self._tool.scm().changed_files(options.git_commit)
> +            state["changed_files"] = changed_files
> +            bug_id = tool.checkout().bug_id_for_this_commit(options.git_commit, changed_files)

Its lame that you need to do this manually.  The steps have a slick way of doing this automatically.
Comment 3 WebKit Commit Bot 2010-10-28 16:01:57 PDT
Comment on attachment 72243 [details]
Patch

Clearing flags on attachment: 72243

Committed r70820: <http://trac.webkit.org/changeset/70820>
Comment 4 WebKit Commit Bot 2010-10-28 16:02:03 PDT
All reviewed patches have been landed.  Closing bug.