Bug 48564

Summary: fast/dom/Window/window-property-descriptors test is broken
Product: WebKit Reporter: Adrienne Walker <enne>
Component: Tools / TestsAssignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enne, jamesr, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
Patch none

Adrienne Walker
Reported 2010-10-28 14:12:07 PDT
https://bugs.webkit.org/show_bug.cgi?id=47853 appears to have broken window-property-descriptors on some platforms. It appears that the platform-specific expectations files were not changed as a part of that bug.
Attachments
Patch (4.07 KB, patch)
2010-10-28 14:16 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2010-10-28 14:16:34 PDT
Created attachment 72234 [details] Patch
Adrienne Walker
Comment 2 2010-10-28 14:20:03 PDT
I just edited the expectations file manually, but I strongly suspect this will do the trick to fix the broken build. Sorry for missing these in the first place. (Maybe webkit-patch should warn about updating the main expectations file and not the platform-specific ones.) Is there some better way to do this rebaselining? The build error here just said failed (http://build.webkit.org/builders/Qt%20Linux%20Release/builds/22771/steps/layout-test/logs/stdio), and I couldn't find the actual output to use and feel more assured that this would fix the problem.
Kenneth Russell
Comment 3 2010-10-28 15:00:24 PDT
Comment on attachment 72234 [details] Patch OK.
WebKit Commit Bot
Comment 4 2010-10-28 15:27:11 PDT
The commit-queue encountered the following flaky tests while processing attachment 72234 [details]: http/tests/misc/copy-resolves-urls.html Please file bugs against the tests. These tests were authored by tony@chromium.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2010-10-28 15:28:06 PDT
Comment on attachment 72234 [details] Patch Clearing flags on attachment: 72234 Committed r70818: <http://trac.webkit.org/changeset/70818>
WebKit Commit Bot
Comment 6 2010-10-28 15:28:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.