Summary: | Mouse events never reach Flash in WebKit2 on Mac (asserts in Debug builds) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, darin, ossy, webkit-ews | ||||
Priority: | P2 | Keywords: | InRadar, PlatformOnly | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
URL: | http://www.communitymx.com/content/source/E5141/wmode.swf | ||||||
Bug Depends on: | 48694 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2010-10-28 13:08:33 PDT
This happens when handling a HandleMouseEnterEvent. Presumably the issue is that WebMouseEvent is 52 bytes in 32-bit builds, and 56 bytes in 64-bit builds. Perhaps this is due to different padding? Seems like we should add a WebEvent.cpp, or perhaps even WebMouseEvent.cpp/h! Created attachment 72415 [details]
Stop using encode/decodeBytes for WebEvent subclasses
Comment on attachment 72415 [details] Stop using encode/decodeBytes for WebEvent subclasses View in context: https://bugs.webkit.org/attachment.cgi?id=72415&action=review > WebKit2/Shared/WebKeyboardEvent.cpp:60 > + t.m_nativeVirtualKeyCode, t.m_isAutoRepeat, t.m_isKeypad, t.m_isSystemKey)); Not sure if it is, but this should all be on one line! Attachment 72415 [details] did not build on qt: Build output: http://queues.webkit.org/results/4853082 Committed r70954: <http://trac.webkit.org/changeset/70954> (In reply to comment #6) > Attachment 72415 [details] did not build on qt: > Build output: http://queues.webkit.org/results/4853082 Guys, it wasn't a fair-play game ... Qt EWS was red, but you committed the wrong patch, and the Qt build is broken since 1,5 hours ago. :-S (In reply to comment #8) > (In reply to comment #6) > > Attachment 72415 [details] [details] did not build on qt: > > Build output: http://queues.webkit.org/results/4853082 > > Guys, it wasn't a fair-play game ... Qt EWS was red, but > you committed the wrong patch, and the Qt build is broken > since 1,5 hours ago. :-S Kling fixed it in http://trac.webkit.org/changeset/70964 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #6) > > > Attachment 72415 [details] [details] [details] did not build on qt: > > > Build output: http://queues.webkit.org/results/4853082 > > > > Guys, it wasn't a fair-play game ... Qt EWS was red, but > > you committed the wrong patch, and the Qt build is broken > > since 1,5 hours ago. :-S > > Kling fixed it in http://trac.webkit.org/changeset/70964 Sorry for the trouble. I've been paying attention to the Qt-EWS in general, and find it extremely useful. I guess I wasn't thinking on this one. Thanks for cleaning up my mess! |