Bug 48548

Summary: [GTK] Avoid font hinting in the DRT
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: S60 3rd edition   
Attachments:
Description Flags
Proposed patch
none
Proposed patch
mrobinson: review+
Rebaseline patch 1
mrobinson: review+
Rebaseline patch 2
mrobinson: review+
Rebaseline patch 3 mrobinson: review+

Description Alejandro G. Castro 2010-10-28 12:16:11 PDT 
We have to avoid activating the hinting when testing with the DRT, it gives different results depending on the distribution
Comment 1 Alejandro G. Castro 2010-10-29 02:33:16 PDT 
Created attachment 72302 [details]
Proposed patch

I'll add the rebaselines to other patches to divide the patch.
Comment 2 Alejandro G. Castro 2010-10-29 02:50:57 PDT 
Created attachment 72307 [details]
Proposed patch

Fix Changelog style, the patch with just the modification to avoid hinting.
Comment 3 Alejandro G. Castro 2010-10-29 02:51:55 PDT 
Created attachment 72308 [details]
Rebaseline patch 1
Comment 4 Alejandro G. Castro 2010-10-29 02:52:23 PDT 
Created attachment 72309 [details]
Rebaseline patch 2
Comment 5 Alejandro G. Castro 2010-10-29 02:52:54 PDT 
Created attachment 72310 [details]
Rebaseline patch 3
Comment 6 Martin Robinson 2010-10-29 09:12:42 PDT 
Comment on attachment 72307 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72307&action=review

> WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp:140
> +    g_object_set(settings, "gtk-xft-antialias", 1, "gtk-xft-hinting", 0, "gtk-font-name", "Liberation Sans 16", NULL);

I think I'd still prefer line breaks betwen all of the pairs here, just for consistency sake.
Comment 7 Martin Robinson 2010-10-29 09:28:21 PDT 
We just need to figure out how to land this without causing grief to everyone else.