Bug 48532

Summary:

Web Inspector: make legacy resource tracking optional in the native code, make cookeis work against new resource manager.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, rniwa, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

48557

Bug Blocks:

Attachments:

Description	Flags
[PATCH] Proposed change.	none
[PATCH] Same with js fixed.	timothy: review+

Pavel Feldman

Reported 2010-10-28 10:21:38 PDT

Patch to follow.

Attachments
[PATCH] Proposed change. (41.88 KB, patch) 2010-10-28 10:37 PDT, Pavel Feldman	no flags	Details Formatted Diff Diff
[PATCH] Same with js fixed. (42.74 KB, patch) 2010-10-28 10:48 PDT, Pavel Feldman	timothy: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2010-10-28 10:37:50 PDT

Created attachment 72206 [details] [PATCH] Proposed change.

Pavel Feldman

Comment 2 2010-10-28 10:48:48 PDT

Created attachment 72207 [details] [PATCH] Same with js fixed.

Pavel Feldman

Comment 3 2010-10-28 13:22:48 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/English.lproj/localizedStrings.js M WebCore/inspector/InspectorCSSStore.cpp M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h M WebCore/inspector/InspectorResource.cpp M WebCore/inspector/InspectorResource.h M WebCore/inspector/InspectorResourceAgent.cpp M WebCore/inspector/front-end/CookieItemsView.js M WebCore/inspector/front-end/Resource.js M WebCore/inspector/front-end/ResourceManager.js M WebCore/inspector/front-end/inspector.js Committed r70800

WebKit Review Bot

Comment 4 2010-10-28 13:54:17 PDT

http://trac.webkit.org/changeset/70800 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/inspector/console-resource-errors.html http/tests/inspector/console-xhr-logging.html

Ryosuke Niwa

Comment 5 2010-10-28 14:37:57 PDT

(In reply to comment #4) > http://trac.webkit.org/changeset/70800 might have broken SnowLeopard Intel Release (Tests) > The following tests are not passing: > http/tests/inspector/console-resource-errors.html > http/tests/inspector/console-xhr-logging.html This indeed seems to be the case. Please investigate the failures.

Note You need to log in before you can comment on or make changes to this bug.