Summary: | Remove obsolete public/API methods in chromium port | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Satish Sampath <satish> | ||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, steveblock | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Satish Sampath
2010-10-28 02:57:28 PDT
Created attachment 72165 [details]
Patch
Comment on attachment 72165 [details]
Patch
Is this correct? It looks like we've taken the implementation from the deprecated method.
The method with 2 parameters is deprecated and WebKit currently calls the 3 parameter method. In chromium, the class implementing this interface only implements the 3 parameter variant. So the 2 parameter variant is no longer needed and is removed here. Pointer to the chromium class which implements this interface: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/speech_input_dispatcher.cc?revision=64213&view=markup Comment on attachment 72165 [details]
Patch
r=me
Comment on attachment 72165 [details] Patch Clearing flags on attachment: 72165 Committed r70769: <http://trac.webkit.org/changeset/70769> All reviewed patches have been landed. Closing bug. |