Bug 48500

Summary:

webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is very slow

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, ddkilzer, eric, evan

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

48565, 48536

Attachments:

Description	Flags
Patch	none
Deploy @memoized to one more place	none

Description Eric Seidel (no email) 2010-10-27 21:26:50 PDT

webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is very slow

Comment 1 Eric Seidel (no email) 2010-10-27 21:30:49 PDT

Created attachment 72137 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-10-27 21:32:47 PDT

Evan (or anyone else): if you have suggestions on how to make our git log codepath faster for Git.revisions_changing_file I'd love to hear them. :)

http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/checkout/scm.py#L676

Comment 3 Eric Seidel (no email) 2010-10-27 21:48:07 PDT

Created attachment 72138 [details]
Deploy @memoized to one more place

Comment 4 Adam Barth 2010-10-27 21:55:43 PDT

Comment on attachment 72138 [details]
Deploy @memoized to one more place

Mind -> blown

Comment 5 WebKit Commit Bot 2010-10-27 22:12:50 PDT

Comment on attachment 72138 [details]
Deploy @memoized to one more place

Clearing flags on attachment: 72138

Committed r70747: <http://trac.webkit.org/changeset/70747>

Comment 6 WebKit Commit Bot 2010-10-27 22:12:56 PDT

All reviewed patches have been landed.  Closing bug.

Comment 7 Evan Martin 2010-10-28 10:09:24 PDT

"git", "log", "--pretty=format:%H", "-%s" % limit, "--", path

is the same as

git rev-list HEAD -- path | head -<limit>

but I expect they have the same big-O