Bug 4849

Summary:

htmltokenizer.cpp won't compile with TOKEN_DEBUG defined

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

New Bugs

Assignee:

Dave Hyatt <hyatt>

Status:

VERIFIED FIXED

Severity:

Trivial

Priority:

Version:

420+

Hardware:

All

OS:

OS X 10.4

Attachments:

Description	Flags
proposed patch	darin: review+

Description Alexey Proskuryakov 2005-09-04 13:10:36 PDT

Several fixes to make it compile cleanly in debug mode (I'm using a locally modified KWQKDebug.h that 
actually prints something).

Comment 1 Alexey Proskuryakov 2005-09-04 13:11:18 PDT

Created attachment 3759 [details]
proposed patch

Comment 2 Oliver Hunt 2005-09-07 03:56:18 PDT

Mark the patch for review

Comment 3 Darin Adler 2005-09-07 08:19:39 PDT

Comment on attachment 3759 [details]
proposed patch

It's really ugly that this includes calls to operator->, and the string is not
guaranteed to be contiguous, so it won't always work.

But on the other hand, at least it compiles. Maybe later we'll just remove all
this code.

r=me