| Summary: | [chromium] Make the test results server store which master the bot is on | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dglazkov, dpranke, eric, evan, tony, victorw, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Ojan Vafai
2010-10-27 15:47:05 PDT
Created attachment 72100 [details]
Patch
Comment on attachment 72100 [details]
Patch
ok
Comment on attachment 72100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72100&action=review > WebKitTools/TestResultServer/model/testfile.py:103 > if not files: Fill in the missing master/test_type here? if not test_type: test_type = "layout-tests" Comment on attachment 72100 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72100&action=review >> WebKitTools/TestResultServer/model/testfile.py:103 >> if not files: > > Fill in the missing master/test_type here? > if not test_type: > test_type = "layout-tests" my intention is to make it master/test_type required. once that's the case, we won't need to fill in master/test_type anywhere. (In reply to comment #4) > (From update of attachment 72100 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=72100&action=review > > >> WebKitTools/TestResultServer/model/testfile.py:103 > >> if not files: > > > > Fill in the missing master/test_type here? > > if not test_type: > > test_type = "layout-tests" > > my intention is to make it master/test_type required. once that's the case, we won't need to fill in master/test_type anywhere. Sounds good then. Thanks for making the change! Committed r70724: <http://trac.webkit.org/changeset/70724> http://trac.webkit.org/changeset/70724 might have broken GTK Linux 32-bit Release |