Bug 48467

Summary: Add VectorMath files
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, eric.carlson, jamesr, jer.noble, kbr, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Rogers 2010-10-27 14:32:28 PDT 
Add VectorMath files
Comment 1 Chris Rogers 2010-10-27 14:35:46 PDT 
Created attachment 72088 [details]
Patch
Comment 2 Kenneth Russell 2010-10-27 14:52:14 PDT 
Comment on attachment 72088 [details]
Patch

These routines should be placed either in a namespace (WebCore / VectorMath) or as static methods on a class. The implementation can then re-direct to Accelerate.framework. Polluting the global namespace on all platforms is very sub-optimal.
Comment 3 Chris Rogers 2010-10-27 15:52:40 PDT 
Created attachment 72101 [details]
Patch
Comment 4 Chris Rogers 2010-10-27 15:54:32 PDT 
Uploaded new patch with namespace changes as requested.
Comment 5 Kenneth Russell 2010-10-27 18:50:08 PDT 
Comment on attachment 72101 [details]
Patch

Looks good.
Comment 6 WebKit Commit Bot 2010-10-27 20:38:19 PDT 
Comment on attachment 72101 [details]
Patch

Clearing flags on attachment: 72101

Committed r70743: <http://trac.webkit.org/changeset/70743>
Comment 7 WebKit Commit Bot 2010-10-27 20:38:25 PDT 
All reviewed patches have been landed.  Closing bug.