Bug 48467

Summary: Add VectorMath files
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, eric.carlson, jamesr, jer.noble, kbr, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Chris Rogers
Reported 2010-10-27 14:32:28 PDT
Add VectorMath files
Attachments
Patch (5.40 KB, patch)
2010-10-27 14:35 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (5.94 KB, patch)
2010-10-27 15:52 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2010-10-27 14:35:46 PDT
Created attachment 72088 [details] Patch
Kenneth Russell
Comment 2 2010-10-27 14:52:14 PDT
Comment on attachment 72088 [details] Patch These routines should be placed either in a namespace (WebCore / VectorMath) or as static methods on a class. The implementation can then re-direct to Accelerate.framework. Polluting the global namespace on all platforms is very sub-optimal.
Chris Rogers
Comment 3 2010-10-27 15:52:40 PDT
Created attachment 72101 [details] Patch
Chris Rogers
Comment 4 2010-10-27 15:54:32 PDT
Uploaded new patch with namespace changes as requested.
Kenneth Russell
Comment 5 2010-10-27 18:50:08 PDT
Comment on attachment 72101 [details] Patch Looks good.
WebKit Commit Bot
Comment 6 2010-10-27 20:38:19 PDT
Comment on attachment 72101 [details] Patch Clearing flags on attachment: 72101 Committed r70743: <http://trac.webkit.org/changeset/70743>
WebKit Commit Bot
Comment 7 2010-10-27 20:38:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.