Bug 48467 - Add VectorMath files
Summary: Add VectorMath files
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2010-10-27 14:32 PDT by Chris Rogers
Modified: 2010-10-27 20:38 PDT (History)
8 users (show)

See Also:

Patch (5.40 KB, patch)
2010-10-27 14:35 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff
Patch (5.94 KB, patch)
2010-10-27 15:52 PDT, Chris Rogers
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2010-10-27 14:32:28 PDT
Add VectorMath files
Comment 1 Chris Rogers 2010-10-27 14:35:46 PDT
Created attachment 72088 [details]
Comment 2 Kenneth Russell 2010-10-27 14:52:14 PDT
Comment on attachment 72088 [details]

These routines should be placed either in a namespace (WebCore / VectorMath) or as static methods on a class. The implementation can then re-direct to Accelerate.framework. Polluting the global namespace on all platforms is very sub-optimal.
Comment 3 Chris Rogers 2010-10-27 15:52:40 PDT
Created attachment 72101 [details]
Comment 4 Chris Rogers 2010-10-27 15:54:32 PDT
Uploaded new patch with namespace changes as requested.
Comment 5 Kenneth Russell 2010-10-27 18:50:08 PDT
Comment on attachment 72101 [details]

Looks good.
Comment 6 WebKit Commit Bot 2010-10-27 20:38:19 PDT
Comment on attachment 72101 [details]

Clearing flags on attachment: 72101

Committed r70743: <http://trac.webkit.org/changeset/70743>
Comment 7 WebKit Commit Bot 2010-10-27 20:38:25 PDT
All reviewed patches have been landed.  Closing bug.