| Summary: | compositing/tiling/huge-layer* flakey | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||||
| Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dglazkov, dino, gyuyoung.kim, jberlin, rakuco, simon.fraser, thorton, webkit.review.bot | ||||||||
| Priority: | P2 | Keywords: | InRadar, LayoutTestFailure, PlatformOnly | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| URL: | http://build.webkit.org/results/Windows%20Release%20(Tests)/r70637%20(5661)/results.html | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=167537 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Adam Roben (:aroben)
2010-10-27 12:33:57 PDT
Here's an example of compositing/tiling/huge-layer-with-layer-children-resize.html passing: <http://build.webkit.org/results/Windows%20Debug%20(Tests)/r70645%20(21640)/results.html>. The tests seem to work OK in the browser. They also sometimes fail on SL WK2: None: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89620%20(12862)/results.html huge-layer-with-children: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89613%20(12861)/results.html huge-layer: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89612%20(12860)/results.html None: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89610%20(12859)/results.html huge-layer-add-remove-child: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89609%20(12858)/results.html I think we should make layerTreeAsText() eagerly update the layer's tiling status to avoid this. Disabled the tests until we can implement Simon's suggestion in http://trac.webkit.org/changeset/89631 Created attachment 170515 [details]
Patch
Comment on attachment 170515 [details]
Patch
rs=me
Comment on attachment 170515 [details] Patch Attachment 170515 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14593106 New failing tests: compositing/tiling/huge-layer-img.html platform/chromium/virtual/softwarecompositing/tiling/huge-layer-img.html Created attachment 170711 [details]
Patch
Comment on attachment 170711 [details] Patch Attachment 170711 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14559736 New failing tests: compositing/tiling/huge-layer-img.html platform/chromium/virtual/softwarecompositing/tiling/huge-layer-img.html Created attachment 170767 [details]
Patch
Comment on attachment 170767 [details]
Patch
Carry mitz's r+ forward.
Comment on attachment 170767 [details] Patch Rejecting attachment 170767 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: yer-with-layer-children-expected.txt patching file LayoutTests/platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt patching file LayoutTests/platform/qt-5.0-wk2/TestExpectations Hunk #2 FAILED at 360. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/qt-5.0-wk2/TestExpectations.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Simon Fras..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14614058 |