Bug 48454

Summary:

compositing/tiling/huge-layer* flakey

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, dino, gyuyoung.kim, jberlin, rakuco, simon.fraser, thorton, webkit.review.bot

Priority:

Keywords:

InRadar, LayoutTestFailure, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

URL:

http://build.webkit.org/results/Windows%20Release%20(Tests)/r70637%20(5661)/results.html

See Also:

https://bugs.webkit.org/show_bug.cgi?id=167537

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	simon.fraser: review+, webkit.review.bot: commit-queue-

Adam Roben (:aroben)

Reported 2010-10-27 12:33:57 PDT

The following two tests sometimes fail on Windows: compositing/tiling/huge-layer-resize.html compositing/tiling/huge-layer-with-layer-children-resize.html See the URL for the diffs. I've added these tests to the Skipped file.

Attachments
Patch (21.35 KB, patch) 2012-10-24 16:54 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (46.19 KB, patch) 2012-10-25 12:32 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (46.79 KB, patch) 2012-10-25 16:40 PDT, Simon Fraser (smfr)	simon.fraser: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2010-10-27 12:34:23 PDT

Here's an example of compositing/tiling/huge-layer-with-layer-children-resize.html passing: <http://build.webkit.org/results/Windows%20Debug%20(Tests)/r70645%20(21640)/results.html>.

Adam Roben (:aroben)

Comment 2 2010-10-27 12:34:59 PDT

The tests seem to work OK in the browser.

Adam Roben (:aroben)

Comment 3 2010-10-27 12:45:14 PDT

<rdar://problem/8601084>

Jessie Berlin

Comment 4 2011-06-23 15:46:31 PDT

They also sometimes fail on SL WK2: None: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89620%20(12862)/results.html huge-layer-with-children: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89613%20(12861)/results.html huge-layer: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89612%20(12860)/results.html None: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89610%20(12859)/results.html huge-layer-add-remove-child: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r89609%20(12858)/results.html

Simon Fraser (smfr)

Comment 5 2011-06-23 15:50:06 PDT

I think we should make layerTreeAsText() eagerly update the layer's tiling status to avoid this.

Jessie Berlin

Comment 6 2011-06-23 16:06:30 PDT

Disabled the tests until we can implement Simon's suggestion in http://trac.webkit.org/changeset/89631

Simon Fraser (smfr)

Comment 7 2012-10-24 16:54:55 PDT

Created attachment 170515 [details] Patch

mitz

Comment 8 2012-10-24 22:00:39 PDT

Comment on attachment 170515 [details] Patch rs=me

WebKit Review Bot

Comment 9 2012-10-24 23:17:02 PDT

Comment on attachment 170515 [details] Patch Attachment 170515 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14593106 New failing tests: compositing/tiling/huge-layer-img.html platform/chromium/virtual/softwarecompositing/tiling/huge-layer-img.html

Simon Fraser (smfr)

Comment 10 2012-10-25 12:32:35 PDT

Created attachment 170711 [details] Patch

WebKit Review Bot

Comment 11 2012-10-25 13:57:01 PDT

Comment on attachment 170711 [details] Patch Attachment 170711 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14559736 New failing tests: compositing/tiling/huge-layer-img.html platform/chromium/virtual/softwarecompositing/tiling/huge-layer-img.html

Simon Fraser (smfr)

Comment 12 2012-10-25 16:40:26 PDT

Created attachment 170767 [details] Patch

Simon Fraser (smfr)

Comment 13 2012-10-26 08:53:38 PDT

Comment on attachment 170767 [details] Patch Carry mitz's r+ forward.

WebKit Review Bot

Comment 14 2012-10-26 09:06:32 PDT

Comment on attachment 170767 [details] Patch Rejecting attachment 170767 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: yer-with-layer-children-expected.txt patching file LayoutTests/platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt patching file LayoutTests/platform/qt-5.0-wk2/TestExpectations Hunk #2 FAILED at 360. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/qt-5.0-wk2/TestExpectations.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Simon Fras..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14614058

Simon Fraser (smfr)

Comment 15 2012-10-26 10:31:07 PDT

http://trac.webkit.org/changeset/132673

Note You need to log in before you can comment on or make changes to this bug.