Bug 48445

Summary: [GTK] r69296 includes a cast from GdkWindow* to GtkWindow*
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch for this issue gustavo: review+

Martin Robinson
Reported 2010-10-27 11:21:44 PDT
r69296 includes a cast from GdkWindow* to GtkWindow*. This is causing a crash in plugins/null-npp-getvalue-pointer.html.
Attachments
Patch for this issue (3.73 KB, patch)
2010-10-27 11:27 PDT, Martin Robinson 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-10-27 11:27:51 PDT
Created attachment 72059 [details] Patch for this issue
Gustavo Noronha (kov)
Comment 2 2010-10-27 11:31:15 PDT
Comment on attachment 72059 [details] Patch for this issue View in context: https://bugs.webkit.org/attachment.cgi?id=72059&action=review > WebCore/ChangeLog:10 > + GdkWindow*. The widget is used to get the proper visual for the > + widget. "The widget is used to get the proper visual for the widget." sounds really weird. Perhaps "for the plugin's container widget"? Otherwise looks right!
Martin Robinson
Comment 3 2010-10-27 11:39:06 PDT
Committed r70677: <http://trac.webkit.org/changeset/70677>
Note You need to log in before you can comment on or make changes to this bug.