Summary: | Fix the dirty rect checks in RenderBoxLineList, InlineFlowBox, InlineTextBox | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||||
Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dimich | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 46123 | ||||||||||
Attachments: |
|
Description
Dave Hyatt
2010-10-27 11:05:46 PDT
Created attachment 72376 [details]
Patch
Comment on attachment 72376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72376&action=review > WebCore/rendering/RenderBox.h:382 > + int convertFromFlippedWritingMode(int); I think a parameter name here would be helpful. Should this instead have a name like "convertFromLogicalToPhysicalVerticalPosition" or just "toPhysicalVerticalPosition"? > WebCore/rendering/RenderLineBoxList.cpp:173 > +bool RenderLineBoxList::anyLinesIntersectDirtyRect(RenderBoxModelObject* renderer, const PaintInfo& paintInfo, int tx, int ty, bool usePrintRect) const I might have moved the "s" from "Lines" to "Intersect": anyLineIntersectsDirtyRect. > WebCore/rendering/RenderLineBoxList.h:74 > private: > + bool anyLinesIntersectDirtyRect(RenderBoxModelObject*, const PaintInfo&, int x, int y, bool usePrintRect) const; > + bool lineIntersectsDirtyRect(RenderBoxModelObject*, InlineFlowBox*, const PaintInfo&, int x, int y) const; > + bool rangeIntersectsDirtyRect(RenderBoxModelObject*, int logicalTop, int logicalBottom, const PaintInfo&, int x, int y) const; > + > +private: What's with the double private:? This seem to brake image compare for fast/blockflow/english-rl-text.html. To repro, run this on post-70917 WebKit, nac build: run-webkit-tests -p LayoutTests/fast/blockflow/english-rl-text.html I'll attach 2 images in a second. Created attachment 72403 [details]
Platform/mac image (expected)
Created attachment 72405 [details]
Actual file as DRT produces
|