Bug 48427

Summary: Wrong instruction form for BKPT
Product: WebKit Reporter: Zoltan Herczeg <zherczeg>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch kling: review+, kling: commit-queue-

Description Zoltan Herczeg 2010-10-27 06:47:42 PDT
One 0 is missing.
Comment 1 Zoltan Herczeg 2010-10-27 06:52:41 PDT
Created attachment 72029 [details]
patch
Comment 2 WebKit Review Bot 2010-10-27 06:56:04 PDT
Attachment 72029 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/assembler/ARMAssembler.h:209:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2010-10-27 07:03:36 PDT
Comment on attachment 72029 [details]
patch

r=me
Comment 4 Andreas Kling 2010-10-27 07:04:22 PDT
Comment on attachment 72029 [details]
patch

Oh, please fix the style error before landing :)
Comment 5 Zoltan Herczeg 2010-10-28 00:23:51 PDT
Thanks for the review.

Landed in http://trac.webkit.org/changeset/70752. Closing bug.