Bug 48427 - Wrong instruction form for BKPT
Summary: Wrong instruction form for BKPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-27 06:47 PDT by Zoltan Herczeg
Modified: 2010-10-28 00:23 PDT (History)
2 users (show)

See Also:


Attachments
patch (1.78 KB, patch)
2010-10-27 06:52 PDT, Zoltan Herczeg
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Herczeg 2010-10-27 06:47:42 PDT
One 0 is missing.
Comment 1 Zoltan Herczeg 2010-10-27 06:52:41 PDT
Created attachment 72029 [details]
patch
Comment 2 WebKit Review Bot 2010-10-27 06:56:04 PDT
Attachment 72029 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/assembler/ARMAssembler.h:209:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2010-10-27 07:03:36 PDT
Comment on attachment 72029 [details]
patch

r=me
Comment 4 Andreas Kling 2010-10-27 07:04:22 PDT
Comment on attachment 72029 [details]
patch

Oh, please fix the style error before landing :)
Comment 5 Zoltan Herczeg 2010-10-28 00:23:51 PDT
Thanks for the review.

Landed in http://trac.webkit.org/changeset/70752. Closing bug.