Summary: | [GTK] Use sentence boundaries instead of start/end sentence | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2010-10-27 05:55:20 PDT
Created attachment 72023 [details] Patch It fixes test fast/dom/Range/range-expand.html, actually it doesn't pass, but sentence tests don't fail, only Chinese word tests are failing because of pango bug https://bugzilla.gnome.org/show_bug.cgi?id=97545 Comment on attachment 72023 [details]
Patch
Great.
Comment on attachment 72023 [details] Patch Rejecting patch 72023 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', 72023]" exit_code: 2 Last 500 characters of output: u'Martin Robinson', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp Hunk #1 FAILED at 300. Hunk #2 FAILED at 315. 2 out of 2 hunks FAILED -- saving rejects to file WebCore/platform/text/gtk/TextBreakIteratorGtk.cpp.rej Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4775046 Comment on attachment 72023 [details]
Patch
It should apply now
Comment on attachment 72023 [details] Patch Clearing flags on attachment: 72023 Committed r71296: <http://trac.webkit.org/changeset/71296> All reviewed patches have been landed. Closing bug. |