Bug 48401

Summary: [Qt] Type mismatch while serializing/deserializing message id size
Product: WebKit Reporter: Kimmo Kinnunen <kimmo.t.kinnunen>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
use same type for sizeof() while reading and writing none

Description Kimmo Kinnunen 2010-10-27 00:14:42 PDT
In WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp, size of the sent buffer is calculated in two ways:
 1) sizeof(uint32_t) when writing
 2) sizeof(MessageId) when reading

This doesn't cause problems at the moment, but might cause them later (or on some obscure compilers).
Comment 1 Kimmo Kinnunen 2010-10-27 00:19:49 PDT
Created attachment 71993 [details]
use same type for sizeof() while reading and writing
Comment 2 Andreas Kling 2010-10-27 02:59:51 PDT
Comment on attachment 71993 [details]
use same type for sizeof() while reading and writing

LGTM.
Comment 3 WebKit Commit Bot 2010-10-27 04:48:34 PDT
Comment on attachment 71993 [details]
use same type for sizeof() while reading and writing

Clearing flags on attachment: 71993

Committed r70635: <http://trac.webkit.org/changeset/70635>
Comment 4 WebKit Commit Bot 2010-10-27 04:48:39 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-10-27 14:03:09 PDT
http://trac.webkit.org/changeset/70635 might have broken GTK Linux 32-bit Release