Bug 48388

Summary:

Add DownloadManager class

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	sam: review+

Description Anders Carlsson 2010-10-26 16:18:42 PDT

Add DownloadManager class

Comment 1 Anders Carlsson 2010-10-26 16:21:01 PDT

Created attachment 71960 [details]
Patch

Comment 2 WebKit Review Bot 2010-10-26 16:24:13 PDT

Attachment 71960 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Downloads/DownloadManager.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Early Warning System Bot 2010-10-26 16:34:18 PDT

Attachment 71960 [details] did not build on qt:
Build output: http://queues.webkit.org/results/4847028

Comment 4 Anders Carlsson 2010-10-26 16:35:53 PDT

Created attachment 71962 [details]
Patch

Comment 5 WebKit Review Bot 2010-10-26 16:40:15 PDT

Attachment 71962 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/Downloads/DownloadManager.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 6 Anders Carlsson 2010-10-27 10:01:22 PDT

Committed r70659: <http://trac.webkit.org/changeset/70659>