Bug 48383

Summary: [CHROMIUM] Add new baselines for canvas tests running on the GPU.
Product: WebKit Reporter: Stephen White <senorblanco>
Component: New BugsAssignee: Stephen White <senorblanco>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for this issue none

Stephen White
Reported 2010-10-26 15:17:56 PDT
Add new baselines for canvas tests running on the GPU.
Attachments
Patch (998.17 KB, patch)
2010-10-26 15:18 PDT, Stephen White 		no flags
DetailsFormatted DiffDiff
Patch for this issue (766.83 KB, text/plain)
2010-10-26 16:16 PDT, Martin Robinson 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Stephen White
Comment 1 2010-10-26 15:18:58 PDT
Created attachment 71949 [details] Patch
Kenneth Russell
Comment 2 2010-10-26 15:40:09 PDT
Comment on attachment 71949 [details] Patch It turns out you don't need review for committing new baselines. Just say something like "Unreviewed, test expectations update". Rubber-stamping because I know you've investigated the correctness of these baselines and have already filed bugs about outstanding issues.
Stephen White
Comment 3 2010-10-26 15:42:09 PDT
(In reply to comment #2) > (From update of attachment 71949 [details]) > It turns out you don't need review for committing new baselines. Just say something like "Unreviewed, test expectations update". Rubber-stamping because I know you've investigated the correctness of these baselines and have already filed bugs about outstanding issues. Thanks. I'm aware of the rubberstamp policy; I mostly wanted to give you a chance to look at the test_expectations change (since it's pretty major). Other than that, you're right; there's not much point in looking at the images.
Stephen White
Comment 4 2010-10-26 15:54:08 PDT
Committed r70582: <http://trac.webkit.org/changeset/70582>
Martin Robinson
Comment 5 2010-10-26 16:16:18 PDT
Created attachment 71958 [details] Patch for this issue
Martin Robinson
Comment 6 2010-10-26 16:17:06 PDT
Sorry. It appears as though webkit-patch chose the wrong bug for my patch.
Note You need to log in before you can comment on or make changes to this bug.