Summary: | GTK: Update resource tracking when moving a frame between documents | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jenn Braithwaite <jennb> | ||||||
Component: | Page Loading | Assignee: | Jenn Braithwaite <jennb> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dimich, mrobinson | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | 44713 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Jenn Braithwaite
2010-10-26 12:31:36 PDT
Created attachment 71961 [details] patch This patch does not add ASSERTs in FrameLoaderClient::dispatchDid{Finish/Fail}Loading to ensure that the test case for bug 44713 would fail without this fix, because there are comments allowing that a resource may not always be found by webkit_web_view_get_resource(). However, to test this change, I did put in the ASSERTs locally to verify the test crashes without the fix, and passes with the fix. Comment on attachment 71961 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=71961&action=review Looks great. Thanks for fixing this for GTK+. There is one small style issue. > WebKit/gtk/webkit/webkitwebview.cpp:4584 > + } else { > + g_hash_table_remove(priv->subResources.get(), identifier); > + } I think that WebKit style requires this last block to go without the curly braces (since it's only one line). Created attachment 72051 [details]
updated patch to fix style issue
Comment on attachment 72051 [details]
updated patch to fix style issue
Looks sane to me.
The commit-queue encountered the following flaky tests while processing attachment 72051 [details]: java/lc3/JSObject/ToObject-001.html Please file bugs against the tests. These tests were authored by ap@webkit.org. The commit-queue is continuing to process your patch. Comment on attachment 72051 [details] updated patch to fix style issue Clearing flags on attachment: 72051 Committed r71090: <http://trac.webkit.org/changeset/71090> All reviewed patches have been landed. Closing bug. |