Summary: | [Qt] Assert due to multiple initialization of WebPlatformStrategies | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||
Component: | WebKit2 | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ademar, commit-queue, kbalazs, kenneth | ||||||
Priority: | P2 | Keywords: | Qt | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
zalan
2010-10-26 07:55:27 PDT
Created attachment 71990 [details]
remove multiple init
Comment on attachment 71990 [details] remove multiple init Clearing flags on attachment: 71990 Committed r70620: <http://trac.webkit.org/changeset/70620> All reviewed patches have been landed. Closing bug. This makes Minibrowser crashing immediately. Created attachment 72024 [details]
second attempt to fix the original issue
Comment on attachment 72024 [details] second attempt to fix the original issue View in context: https://bugs.webkit.org/attachment.cgi?id=72024&action=review r=me, one comment: > WebKit2/UIProcess/API/qt/qwkpage.cpp:55 > + if (!initialized) { Use early return. oh, sorry. i was about to post the fix on that. (In reply to comment #6) > (From update of attachment 72024 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=72024&action=review > > r=me, one comment: > > > WebKit2/UIProcess/API/qt/qwkpage.cpp:55 > > + if (!initialized) { > > Use early return. I will. I know that this is the preferred style, but personally I hate that. There are a lot situations where the early return makes the code harder to read. Committed in http://trac.webkit.org/changeset/70645 |