| Summary: | Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-in.html | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mike Lawther <mikelawther> | ||||||
| Component: | Canvas | Assignee: | Julien Chaffraix <jchaffraix> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | jchaffraix, mdelaney7, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 46506 | ||||||||
| Attachments: |
|
||||||||
|
Description
Mike Lawther
2010-10-25 22:22:32 PDT
Created attachment 96690 [details]
Proposed fix: Add CompositeDestinationIn to the 'display transparency elsewhere' list
Created attachment 96979 [details]
Proposed fix: Same as previously with a comment about destination-out.
Comment on attachment 96979 [details]
Proposed fix: Same as previously with a comment about destination-out.
I think you'll need to update the pixel baselines for at least canvas-composited.html (note that there are 7 different -expected.png files for this). Could you add = IMAGE lines for chromium's test_expectations.txt at least so this doesn't make the bots red, and then rebaseline after landing? The other ports don't run pixel tests on the bots so it's very difficult to update expectations for those.
Other than that this looks great.
Comment on attachment 96979 [details] Proposed fix: Same as previously with a comment about destination-out. > I think you'll need to update the pixel baselines for at least canvas-composited.html (note that there are 7 different -expected.png files for this). Could you add = IMAGE lines for chromium's test_expectations.txt at least so this doesn't make the bots red, and then rebaseline after landing? The other ports don't run pixel tests on the bots so it's very difficult to update expectations for those. Actually it is already in the test_expectations.txt (see bug 61470) due to the anti-aliasing when clipping out. Comment on attachment 96979 [details] Proposed fix: Same as previously with a comment about destination-out. Clearing flags on attachment: 96979 Committed r88896: <http://trac.webkit.org/changeset/88896> All reviewed patches have been landed. Closing bug. |