Bug 48274

Summary:

compile TestNetscapePlugIn on chromium linux

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

New Bugs

Assignee:

Tony Chang <tony>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, tkent

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	andersca: review+

Description Tony Chang 2010-10-25 16:19:05 PDT

compile TestNetscapePlugIn on chromium linux

Comment 1 Tony Chang 2010-10-25 16:22:16 PDT

Created attachment 71810 [details]
Patch

Comment 2 Tony Chang 2010-10-25 16:31:56 PDT

This compiles the plugin on Linux, but doesn't put it in a place that DRT will load it.  There are some crashes with this plugin that I want to fix before switching to this plugin.

Comment 3 Kent Tamura 2010-10-25 19:35:04 PDT

Comment on attachment 71810 [details]
Patch

Chromium part looks ok.

Comment 4 Tony Chang 2010-10-26 18:14:59 PDT

andersca: Can you review the changes to TestNetscapePlugIn/main.cpp or direct me at someone who would be an appropriate reviewer?

Comment 5 Anders Carlsson 2010-10-27 09:52:35 PDT

Comment on attachment 71810 [details]
Patch

This is great! Hopefully it can be a first step towards eliminating the extra unix-specific TestNetscapePlugin implementation! r=me

Comment 6 Tony Chang 2010-10-27 11:42:41 PDT

Committed r70679: <http://trac.webkit.org/changeset/70679>