| Summary: | Web Inspector: stub out basic WebInspector API and objects for WebKit2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Timothy Hatcher <timothy> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, sam, timothy, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Timothy Hatcher
2010-10-25 14:27:17 PDT
Created attachment 71797 [details]
Proposed Change
Comment on attachment 71797 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=71797&action=review Looks great! r=me with some comments. > WebKit2/UIProcess/WebPageProxy.h:112 > + WebInspectorProxy* inspector() const; I don't think inspector() needs to be const. > WebKit2/UIProcess/WebPageProxy.h:329 > + mutable RefPtr<WebInspectorProxy> m_inspector; And then you can remove mutable here (and get rid of the const_cast in the create function). > WebKit2/WebProcess/WebPage/WebPage.h:99 > + WebInspector* inspector() const; Same comment about inspector being const here. |