Bug 48261

Summary: Web Inspector: continue making resources panel optional.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 48332    
Bug Blocks:    
Attachments:
Description Flags
[PATCH] Proposed change. timothy: review+

Pavel Feldman
Reported 2010-10-25 13:01:22 PDT
This refactoring makes console, audits and extensions tests pass while taking data from resource / network panels depending on the flag.
Attachments
[PATCH] Proposed change. (26.93 KB, patch)
2010-10-25 13:28 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2010-10-25 13:28:32 PDT
Created attachment 71790 [details] [PATCH] Proposed change.
Pavel Feldman
Comment 2 2010-10-26 06:53:20 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/http/tests/inspector/inspector-test2.js M LayoutTests/http/tests/inspector/resource-parameters.html M LayoutTests/inspector/audits-panel-functional.html M LayoutTests/inspector/styles-source-offsets.html M WebCore/ChangeLog M WebCore/inspector/front-end/AuditLauncherView.js M WebCore/inspector/front-end/AuditsPanel.js M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/CookieItemsView.js M WebCore/inspector/front-end/ExtensionServer.js M WebCore/inspector/front-end/HAREntry.js M WebCore/inspector/front-end/NetworkPanel.js M WebCore/inspector/front-end/Resource.js M WebCore/inspector/front-end/ResourceCategory.js M WebCore/inspector/front-end/ResourceManager.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/ScriptsPanel.js M WebCore/inspector/front-end/StylesSidebarPane.js M WebCore/inspector/front-end/inspector.js Committed r70518
WebKit Review Bot
Comment 3 2010-10-26 07:29:47 PDT
http://trac.webkit.org/changeset/70518 might have broken Qt Linux Release The following tests are not passing: inspector/audits-panel-functional.html
Pavel Feldman
Comment 4 2010-10-26 10:08:13 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/http/tests/inspector/inspector-test2.js M LayoutTests/http/tests/inspector/resource-parameters.html M LayoutTests/inspector/audits-panel-functional.html M LayoutTests/inspector/styles-source-offsets.html M WebCore/ChangeLog M WebCore/inspector/front-end/AuditLauncherView.js M WebCore/inspector/front-end/AuditsPanel.js M WebCore/inspector/front-end/ConsoleView.js M WebCore/inspector/front-end/CookieItemsView.js M WebCore/inspector/front-end/ExtensionServer.js M WebCore/inspector/front-end/HAREntry.js M WebCore/inspector/front-end/NetworkPanel.js M WebCore/inspector/front-end/Resource.js M WebCore/inspector/front-end/ResourceCategory.js M WebCore/inspector/front-end/ResourceManager.js M WebCore/inspector/front-end/ResourcesPanel.js M WebCore/inspector/front-end/ScriptsPanel.js M WebCore/inspector/front-end/StylesSidebarPane.js M WebCore/inspector/front-end/inspector.js Committed r70532
WebKit Review Bot
Comment 5 2010-10-26 10:33:25 PDT
http://trac.webkit.org/changeset/70532 might have broken Qt Linux Release The following tests are not passing: inspector/audits-panel-functional.html
Note You need to log in before you can comment on or make changes to this bug.