Bug 48253

Summary: Control + Mousewheel shouldn't be handled in WebKit2
Product: WebKit Reporter: Brian Weinstein <bweinstein>
Component: WebKit2Assignee: Brian Weinstein <bweinstein>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
[PATCH] Fix aroben: review+, bweinstein: commit-queue-

Brian Weinstein
Reported 2010-10-25 11:23:33 PDT
WebKit2's WebView shouldn't handle Control + Mousewheel.
Attachments
[PATCH] Fix (1.93 KB, patch)
2010-10-25 11:26 PDT, Brian Weinstein 		aroben: review+
bweinstein: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brian Weinstein
Comment 1 2010-10-25 11:26:02 PDT
Created attachment 71773 [details] [PATCH] Fix
Adam Roben (:aroben)
Comment 2 2010-10-25 12:27:41 PDT
Comment on attachment 71773 [details] [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=71773&action=review > WebKit2/UIProcess/win/WebView.cpp:319 > + // We do not want WebKit to handle Control + Wheel, this should be handled by the App. I'd say "handled by the client application to zoom the page" instead of "handled by the App".
Brian Weinstein
Comment 3 2010-10-25 12:48:23 PDT
(In reply to comment #2) > (From update of attachment 71773 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71773&action=review > > > WebKit2/UIProcess/win/WebView.cpp:319 > > + // We do not want WebKit to handle Control + Wheel, this should be handled by the App. > > I'd say "handled by the client application to zoom the page" instead of "handled by the App". Fixed. Thanks!
Brian Weinstein
Comment 4 2010-10-25 13:12:13 PDT
Landed in r70479.
Note You need to log in before you can comment on or make changes to this bug.