Bug 48253 - Control + Mousewheel shouldn't be handled in WebKit2
Summary: Control + Mousewheel shouldn't be handled in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-25 11:23 PDT by Brian Weinstein
Modified: 2010-10-25 13:12 PDT (History)
2 users (show)

See Also:

Attachments
[PATCH] Fix (1.93 KB, patch)
2010-10-25 11:26 PDT, Brian Weinstein 		aroben: review+
bweinstein: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2010-10-25 11:23:33 PDT 
WebKit2's WebView shouldn't handle Control + Mousewheel.
Comment 1 Brian Weinstein 2010-10-25 11:26:02 PDT 
Created attachment 71773 [details]
[PATCH] Fix
Comment 2 Adam Roben (:aroben) 2010-10-25 12:27:41 PDT 
Comment on attachment 71773 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=71773&action=review

> WebKit2/UIProcess/win/WebView.cpp:319
> +        // We do not want WebKit to handle Control + Wheel, this should be handled by the App.

I'd say "handled by the client application to zoom the page" instead of "handled by the App".
Comment 3 Brian Weinstein 2010-10-25 12:48:23 PDT 
(In reply to comment #2)
> (From update of attachment 71773 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71773&action=review
> 
> > WebKit2/UIProcess/win/WebView.cpp:319
> > +        // We do not want WebKit to handle Control + Wheel, this should be handled by the App.
> 
> I'd say "handled by the client application to zoom the page" instead of "handled by the App".

Fixed. Thanks!
Comment 4 Brian Weinstein 2010-10-25 13:12:13 PDT 
Landed in r70479.