Bug 48233

Summary:

Add support for loading each test several times in chromium DumpRenderTree

Product:

WebKit

Reporter:

Søren Gjesse <sgjesse>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch to add multiple load of each test	none
Fixed tabes in ChangeLog file	none

Søren Gjesse

Reported 2010-10-25 06:32:59 PDT

As the code generated by V8 changes as it is running (e.g. when inline caches change state) some bugs needs to have a test loaded several times for it to be revealed. E.g. http://crbug.com/60135. The chromium DumpRenderTree should have support for that.

Attachments
Patch to add multiple load of each test (9.24 KB, patch) 2010-10-25 06:47 PDT, Søren Gjesse	no flags	Details Formatted Diff Diff
Fixed tabes in ChangeLog file (9.28 KB, patch) 2010-10-25 07:04 PDT, Søren Gjesse	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Søren Gjesse

Comment 1 2010-10-25 06:47:18 PDT

Created attachment 71741 [details] Patch to add multiple load of each test

WebKit Review Bot

Comment 2 2010-10-25 06:51:21 PDT

Attachment 71741 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WebKitTools/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] WebKitTools/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] WebKitTools/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] WebKitTools/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] WebKitTools/ChangeLog:14: Line contains tab character. [whitespace/tab] [5] Total errors found: 6 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Søren Gjesse

Comment 3 2010-10-25 07:04:11 PDT

Created attachment 71744 [details] Fixed tabes in ChangeLog file

Dimitri Glazkov (Google)

Comment 4 2010-10-25 09:27:46 PDT

Comment on attachment 71744 [details] Fixed tabes in ChangeLog file This looks good, but I would like tkent to take a look to make sure this doesn't interfere with his current work.

Kent Tamura

Comment 5 2010-10-25 18:33:05 PDT

Comment on attachment 71744 [details] Fixed tabes in ChangeLog file > This looks good, but I would like tkent to take a look to make sure this doesn't interfere with his current work. No problem.

WebKit Commit Bot

Comment 6 2010-10-26 10:54:57 PDT

Comment on attachment 71744 [details] Fixed tabes in ChangeLog file Clearing flags on attachment: 71744 Committed r70537: <http://trac.webkit.org/changeset/70537>

WebKit Commit Bot

Comment 7 2010-10-26 10:55:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.