Bug 48229

Summary: Replace _countof with WTF_ARRAY_LENGTH
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Web Template FrameworkAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue, ddkilzer, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Patrick R. Gansterer
Reported 2010-10-25 05:01:58 PDT
see patch
Attachments
Patch (14.60 KB, patch)
2010-10-25 05:10 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (14.60 KB, patch)
2010-10-25 05:14 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-10-25 05:10:08 PDT
Created attachment 71736 [details] Patch
WebKit Review Bot
Comment 2 2010-10-25 05:13:02 PDT
Attachment 71736 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/plugins/win/PluginDatabaseWin.cpp:409: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Patrick R. Gansterer
Comment 3 2010-10-25 05:14:58 PDT
Created attachment 71737 [details] Patch Fix style
David Kilzer (:ddkilzer)
Comment 4 2010-10-25 09:10:49 PDT
Comment on attachment 71737 [details] Patch r=me I assume that assigning to the DWORD type doesn't require a cast on Windows [CE].
WebKit Commit Bot
Comment 5 2010-10-25 10:03:46 PDT
Comment on attachment 71737 [details] Patch Clearing flags on attachment: 71737 Committed r70460: <http://trac.webkit.org/changeset/70460>
WebKit Commit Bot
Comment 6 2010-10-25 10:03:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.