Bug 48229

Summary: Replace _countof with WTF_ARRAY_LENGTH
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Web Template FrameworkAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue, ddkilzer, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Patrick R. Gansterer 2010-10-25 05:01:58 PDT 
see patch
Comment 1 Patrick R. Gansterer 2010-10-25 05:10:08 PDT 
Created attachment 71736 [details]
Patch
Comment 2 WebKit Review Bot 2010-10-25 05:13:02 PDT 
Attachment 71736 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/plugins/win/PluginDatabaseWin.cpp:409:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Patrick R. Gansterer 2010-10-25 05:14:58 PDT 
Created attachment 71737 [details]
Patch

Fix style
Comment 4 David Kilzer (:ddkilzer) 2010-10-25 09:10:49 PDT 
Comment on attachment 71737 [details]
Patch

r=me

I assume that assigning to the DWORD type doesn't require a cast on Windows [CE].
Comment 5 WebKit Commit Bot 2010-10-25 10:03:46 PDT 
Comment on attachment 71737 [details]
Patch

Clearing flags on attachment: 71737

Committed r70460: <http://trac.webkit.org/changeset/70460>
Comment 6 WebKit Commit Bot 2010-10-25 10:03:51 PDT 
All reviewed patches have been landed.  Closing bug.