Bug 48228

Summary: Use WTF::StringHasher::createBlobHash where possible
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Web Template FrameworkAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Stack trace of recent GTK+ assertion failures none

Patrick R. Gansterer
Reported 2010-10-25 04:42:43 PDT
see patch
Attachments
Patch (11.87 KB, patch)
2010-10-25 04:54 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Stack trace of recent GTK+ assertion failures (56.63 KB, text/html)
2010-11-01 08:49 PDT, Martin Robinson 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-10-25 04:54:44 PDT
Created attachment 71733 [details] Patch
Adam Barth
Comment 2 2010-10-27 13:07:20 PDT
Comment on attachment 71733 [details] Patch Quite nice. Thanks.
WebKit Commit Bot
Comment 3 2010-10-27 14:05:44 PDT
Comment on attachment 71733 [details] Patch Clearing flags on attachment: 71733 Committed r70705: <http://trac.webkit.org/changeset/70705>
WebKit Commit Bot
Comment 4 2010-10-27 14:05:49 PDT
All reviewed patches have been landed. Closing bug.
Martin Robinson
Comment 5 2010-11-01 08:48:47 PDT
Since this patch landed the 64-bit GTK+ Debug bot has had random assertion failures in the FontCache code and general flakiness with respect to layout test font metrics. I think this patch might be the culprit. I've attached a stack trace of one of these failures.
Martin Robinson
Comment 6 2010-11-01 08:49:37 PDT
Created attachment 72512 [details] Stack trace of recent GTK+ assertion failures
Patrick R. Gansterer
Comment 7 2010-11-01 10:10:08 PDT
(In reply to comment #6) > Created an attachment (id=72512) [details] > Stack trace of recent GTK+ assertion failures Is "ASSERT(!lookupForWriting(Extractor::extract(entry)).second)" the assertion you reach? Do you see any code which changed behavior in this patch? Is this the only bug in the blame list?
Note You need to log in before you can comment on or make changes to this bug.