Summary: | Use WTF::StringHasher::createBlobHash where possible | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||
Component: | Web Template Framework | Assignee: | Patrick R. Gansterer <paroga> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Patrick R. Gansterer
2010-10-25 04:42:43 PDT
Created attachment 71733 [details]
Patch
Comment on attachment 71733 [details]
Patch
Quite nice. Thanks.
Comment on attachment 71733 [details] Patch Clearing flags on attachment: 71733 Committed r70705: <http://trac.webkit.org/changeset/70705> All reviewed patches have been landed. Closing bug. Since this patch landed the 64-bit GTK+ Debug bot has had random assertion failures in the FontCache code and general flakiness with respect to layout test font metrics. I think this patch might be the culprit. I've attached a stack trace of one of these failures. Created attachment 72512 [details]
Stack trace of recent GTK+ assertion failures
(In reply to comment #6) > Created an attachment (id=72512) [details] > Stack trace of recent GTK+ assertion failures Is "ASSERT(!lookupForWriting(Extractor::extract(entry)).second)" the assertion you reach? Do you see any code which changed behavior in this patch? Is this the only bug in the blame list? |