Bug 48219

Summary: Expose HitTestResult::absoluteMediaURL() via WebKit API
Product: WebKit Reporter: mitz
Component: WebKit APIAssignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

mitz
Reported 2010-10-24 19:13:58 PDT
Expose HitTestResult::absoluteMediaURL() via WebKit API
Attachments
Patch (6.76 KB, patch)
2010-10-24 19:37 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Patch (7.20 KB, patch)
2010-10-24 20:17 PDT, mitz 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2010-10-24 19:37:13 PDT
Created attachment 71709 [details] Patch
WebKit Review Bot
Comment 2 2010-10-24 19:39:38 PDT
Attachment 71709 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/win/WebElementPropertyBag.cpp:165: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] WebKit/mac/WebView/WebViewPrivate.h:70: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2010-10-24 20:17:48 PDT
Created attachment 71711 [details] Patch Export the key from WebKit.
WebKit Review Bot
Comment 4 2010-10-24 20:20:30 PDT
Attachment 71711 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/win/WebElementPropertyBag.cpp:165: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] WebKit/mac/WebView/WebViewPrivate.h:70: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 5 2010-10-24 22:18:21 PDT
Committed <trac.webkit.org/changeset/70435>.
Note You need to log in before you can comment on or make changes to this bug.