Bug 48219

Summary:

Expose HitTestResult::absoluteMediaURL() via WebKit API

Product:

WebKit

Reporter:

mitz

Component:

WebKit API

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	andersca: review+

Description mitz 2010-10-24 19:13:58 PDT

Expose HitTestResult::absoluteMediaURL() via WebKit API

Comment 1 mitz 2010-10-24 19:37:13 PDT

Created attachment 71709 [details]
Patch

Comment 2 WebKit Review Bot 2010-10-24 19:39:38 PDT

Attachment 71709 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/win/WebElementPropertyBag.cpp:165:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebKit/mac/WebView/WebViewPrivate.h:70:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 mitz 2010-10-24 20:17:48 PDT

Created attachment 71711 [details]
Patch

Export the key from WebKit.

Comment 4 WebKit Review Bot 2010-10-24 20:20:30 PDT

Attachment 71711 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/win/WebElementPropertyBag.cpp:165:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
WebKit/mac/WebView/WebViewPrivate.h:70:  One space before end of line comments  [whitespace/comments] [5]
Total errors found: 2 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 mitz 2010-10-24 22:18:21 PDT

Committed <trac.webkit.org/changeset/70435>.