| Summary: | SVGTextElement supplemental transforms pre-multiplied but should be post-multiplied in animatedLocalTransform | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Shane Stephens <shanestephens> | ||||||
| Component: | New Bugs | Assignee: | Shane Stephens <shanestephens> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, krit, noel.gordon, webkit.review.bot, zimmermann | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 48031 | ||||||||
| Attachments: |
|
||||||||
|
Description
Shane Stephens
2010-10-24 17:09:34 PDT
Created attachment 71701 [details]
Patch
Comment on attachment 71701 [details]
Patch
Does this only apply to elements with local transform in combination of animateMotion, what about animateTransform? If you need animation tests, you should use the animation test api in svg/animations. Please take a look there. Using setTimeout is definitely wrong.
If it does not only effect animateMotion, I'd like to see more tests.
Created attachment 73396 [details]
Patch
Comment on attachment 73396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73396&action=review r=me > WebCore/ChangeLog:17 > + Switched order of multiplication. Note that due to a bug in > + AffineTransform's operator* implementation the order of arguments is > + reversed (see http://bugs.webkit.org/show_bug.cgi?id=48031). > + Please add a comment that this will be fixed in a followup. Comment on attachment 73396 [details]
Patch
My next patch depends on this fix, setting cq+ to get it in ASAP.
The commit-queue encountered the following flaky tests while processing attachment 73396 [details]:
http/tests/appcache/reload.html
Please file bugs against the tests. The commit-queue is continuing to process your patch.
Comment on attachment 73396 [details] Patch Clearing flags on attachment: 73396 Committed r71726: <http://trac.webkit.org/changeset/71726> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/71726 might have broken Qt Linux Release The following tests are not passing: svg/animations/animate-text-nested-transforms.html (In reply to comment #9) > http://trac.webkit.org/changeset/71726 might have broken Qt Linux Release > The following tests are not passing: > svg/animations/animate-text-nested-transforms.html Same problem as bug 49045. |