Bug 48215

Summary: SVGTextElement supplemental transforms pre-multiplied but should be post-multiplied in animatedLocalTransform
Product: WebKit Reporter: Shane Stephens <shanestephens>
Component: New BugsAssignee: Shane Stephens <shanestephens>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, krit, noel.gordon, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 48031    
Attachments:
Description Flags
Patch
none
Patch none

Shane Stephens
Reported 2010-10-24 17:09:34 PDT
SVGTextElement supplemental transforms pre-multiplied but should be post-multiplied in animatedLocalTransform
Attachments
Patch (4.33 KB, patch)
2010-10-24 17:14 PDT, Shane Stephens 		no flags
DetailsFormatted DiffDiff
Patch (6.36 KB, patch)
2010-11-09 11:58 PST, Shane Stephens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shane Stephens
Comment 1 2010-10-24 17:14:43 PDT
Created attachment 71701 [details] Patch
Dirk Schulze
Comment 2 2010-10-26 23:13:56 PDT
Comment on attachment 71701 [details] Patch Does this only apply to elements with local transform in combination of animateMotion, what about animateTransform? If you need animation tests, you should use the animation test api in svg/animations. Please take a look there. Using setTimeout is definitely wrong. If it does not only effect animateMotion, I'd like to see more tests.
Shane Stephens
Comment 3 2010-11-09 11:58:45 PST
Created attachment 73396 [details] Patch
Dirk Schulze
Comment 4 2010-11-09 23:45:33 PST
Comment on attachment 73396 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73396&action=review r=me > WebCore/ChangeLog:17 > + Switched order of multiplication. Note that due to a bug in > + AffineTransform's operator* implementation the order of arguments is > + reversed (see http://bugs.webkit.org/show_bug.cgi?id=48031). > + Please add a comment that this will be fixed in a followup.
Nikolas Zimmermann
Comment 5 2010-11-10 00:25:52 PST
Comment on attachment 73396 [details] Patch My next patch depends on this fix, setting cq+ to get it in ASAP.
WebKit Commit Bot
Comment 6 2010-11-10 01:01:44 PST
The commit-queue encountered the following flaky tests while processing attachment 73396 [details]: http/tests/appcache/reload.html Please file bugs against the tests. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2010-11-10 01:04:29 PST
Comment on attachment 73396 [details] Patch Clearing flags on attachment: 73396 Committed r71726: <http://trac.webkit.org/changeset/71726>
WebKit Commit Bot
Comment 8 2010-11-10 01:04:35 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 9 2010-11-10 01:25:35 PST
http://trac.webkit.org/changeset/71726 might have broken Qt Linux Release The following tests are not passing: svg/animations/animate-text-nested-transforms.html
Nikolas Zimmermann
Comment 10 2010-11-10 02:10:25 PST
(In reply to comment #9) > http://trac.webkit.org/changeset/71726 might have broken Qt Linux Release > The following tests are not passing: > svg/animations/animate-text-nested-transforms.html Same problem as bug 49045.
Note You need to log in before you can comment on or make changes to this bug.