Bug 48197

Summary: Remove unused method HTMLFrameElementBase::setNameAndOpenURLCallback()
Product: WebKit Reporter: Daniel Bates <dbates>
Component: DOMAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2010-10-23 17:47:24 PDT
We should remove the method HTMLFrameElementBase::setNameAndOpenURLCallback() since it is unused. For completeness, this method was added in changeset 24396 <http://trac.webkit.org/changeset/24396> and had one call site in HTMLFrameElementBase::attach(). This call site was removed in changeset 67182 <http://trac.webkit.org/changeset/67182>.
Attachments
Patch (2.10 KB, patch)
2010-10-23 18:02 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2010-10-23 18:02:20 PDT
Created attachment 71662 [details] Patch No functionality was changed. So, no new tests.
WebKit Commit Bot
Comment 2 2010-10-23 19:19:06 PDT
The commit-queue encountered the following flaky tests while processing attachment 71662 [details]: http/tests/appcache/credential-url.html Please file bugs against the tests. The author(s) of the test(s) are jchaffraix@webkit.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2010-10-23 19:19:46 PDT
Comment on attachment 71662 [details] Patch Clearing flags on attachment: 71662 Committed r70407: <http://trac.webkit.org/changeset/70407>
WebKit Commit Bot
Comment 4 2010-10-23 19:19:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.