Bug 48187

Summary: webkit-patch upload fails when the patch removes a file
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 48272    
Attachments:
Description Flags
Patch none

David Kilzer (:ddkilzer)
Reported 2010-10-23 08:36:43 PDT
When webkit-patch upload attempts to process a patch that removes a file (for Bug 48186), it fails: $ ./WebKitTools/Scripts/webkit-patch upload -m "Patch v1" --open-bug --suggest-reviewers -g HEAD 48186 Running check-webkit-style Total errors found: 0 in 4 files 3 files to edit Was that diff correct? [Y/n]: y Fetching: https://bugs.webkit.org/show_bug.cgi?id=48186&ctype=xml Failed to run "[u'git', u'log', u'--pretty=format:%H', u'-5', u'/Volumes/Data/WebKit.git/WebKit/mac/WebView/WebHTMLRepresentationInternal.h']" exit_code: 128 fatal: ambiguous argument '/Volumes/Data/WebKit.git/WebKit/mac/WebView/WebHTMLRepresentationInternal.h': unknown revision or path not in the working tree. Use '--' to separate paths from revisions Failed to run "[u'git', u'log', u'--pretty=format:%H', u'-5', u'/Volumes/Data/WebKit.git/WebKit/mac/WebView/WebHTMLRepresentationInternal.h']" exit_code: 128
Attachments
Patch (1.39 KB, patch)
2010-10-24 20:51 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-10-23 09:35:40 PDT
Thanks for the report. We need to add -- before the file names.
Adam Barth
Comment 2 2010-10-24 20:51:25 PDT
Created attachment 71713 [details] Patch
David Kilzer (:ddkilzer)
Comment 3 2010-10-24 21:10:01 PDT
Comment on attachment 71713 [details] Patch Thanks! r=me
WebKit Commit Bot
Comment 4 2010-10-24 22:30:39 PDT
Comment on attachment 71713 [details] Patch Clearing flags on attachment: 71713 Committed r70437: <http://trac.webkit.org/changeset/70437>
WebKit Commit Bot
Comment 5 2010-10-24 22:30:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.