Bug 48181

Summary: Add missing include of MacErrors.h
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebCore Misc.Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue, darin, jianli
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on: 32993    
Bug Blocks:    
Attachments:
Description Flags
Patch v1
none
Patch v2 none

Description David Kilzer (:ddkilzer) 2010-10-23 05:19:42 PDT 
Add missing include of MacErrors.h
Comment 1 David Kilzer (:ddkilzer) 2010-10-23 05:23:17 PDT 
Created attachment 71635 [details]
Patch v1
Comment 2 WebKit Commit Bot 2010-10-23 08:28:00 PDT 
Comment on attachment 71635 [details]
Patch v1

Rejecting patch 71635 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
N_MINOR 0320
    setenv YACC /Developer/usr/bin/yacc
    /bin/sh -c /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Script-5DF50887116F3077005202AB.sh

** BUILD FAILED **


The following build commands failed:
WebCore:
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/FormDataStreamMac.o /Projects/CommitQueue/WebCore/platform/network/mac/FormDataStreamMac.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2
(1 failure)


Full output: http://queues.webkit.org/results/4675043
Comment 3 David Kilzer (:ddkilzer) 2010-10-23 08:28:37 PDT 
Comment on attachment 71635 [details]
Patch v1

Clearing flags.  Apparently fnfErr is defined elsewhere.
Comment 4 David Kilzer (:ddkilzer) 2010-10-23 10:50:43 PDT 
Created attachment 71647 [details]
Patch v2
Comment 5 Alexey Proskuryakov 2010-10-23 13:11:55 PDT 
Comment on attachment 71647 [details]
Patch v2

It took me some time to understand why Mac path also needed to be modified. Currently, Mac gets CoreServices through WebCorePrefix.h, and we want the code to build without it.
Comment 6 David Kilzer (:ddkilzer) 2010-10-23 13:33:03 PDT 
(In reply to comment #5)
> (From update of attachment 71647 [details])
> It took me some time to understand why Mac path also needed to be modified. Currently, Mac gets CoreServices through WebCorePrefix.h, and we want the code to build without it.

Thanks. Yes, MacErrors.h is part of CarbonCore.framework which is a sub-framework of CoreServices.framework.
Comment 7 WebKit Commit Bot 2010-10-23 13:53:33 PDT 
Comment on attachment 71647 [details]
Patch v2

Clearing flags on attachment: 71647

Committed r70399: <http://trac.webkit.org/changeset/70399>
Comment 8 WebKit Commit Bot 2010-10-23 13:53:38 PDT 
All reviewed patches have been landed.  Closing bug.