Bug 48171

Summary: EWS never releases patches which fail to apply
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 35460    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2010-10-22 23:03:27 PDT
EWS never releases patches which fail to apply
Attachments
Patch (3.04 KB, patch)
2010-10-22 23:07 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-10-22 23:07:14 PDT
Created attachment 71622 [details] Patch
Eric Seidel (no email)
Comment 2 2010-10-22 23:08:40 PDT
This explains 10 of the 11 patches that the Qt-EWS is stuck chewing on (and countless others from other queues). The /release-patch design is fragile. We need to come up with a cleaner pattern through which to release patches.
Adam Barth
Comment 3 2010-10-22 23:32:52 PDT
Comment on attachment 71622 [details] Patch i wish there was a more central place to put these calls to release_work_item.
Eric Seidel (no email)
Comment 4 2010-10-22 23:42:52 PDT
There probably are. We need to finish patching holes in the dam and then sit back and make a sane design out of all this. :)
Eric Seidel (no email)
Comment 5 2010-10-22 23:43:24 PDT
We also need to split release_work_item into two methods: remove_work_item and unlock_work_item (or similar names).
WebKit Commit Bot
Comment 6 2010-10-22 23:47:56 PDT
Comment on attachment 71622 [details] Patch Clearing flags on attachment: 71622 Committed r70382: <http://trac.webkit.org/changeset/70382>
WebKit Commit Bot
Comment 7 2010-10-22 23:48:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.