Bug 48165

Summary:

commit-queue should not pass --quiet to subcommands now that the parent command does the reporting

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	abarth: review+, abarth: commit-queue-

Eric Seidel (no email)

Reported 2010-10-22 17:13:51 PDT

commit-queue should not pass --quiet to subcommands now that the parent command does the reporting

Attachments
Patch (17.53 KB, patch) 2010-10-22 17:15 PDT, Eric Seidel (no email)	abarth: review+ abarth: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-10-22 17:15:21 PDT

Created attachment 71614 [details] Patch

Adam Barth

Comment 2 2010-10-22 17:16:23 PDT

Comment on attachment 71614 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71614&action=review Ok. Are we going to run out of disk space? :) > WebKitTools/Scripts/webkitpy/tool/bot/commitqueuetask.py:144 > + # Unclear if this should pass --quiet or not. If --parent-command always does the reporting, than it should. than => then

Eric Seidel (no email)

Comment 3 2010-10-22 17:38:14 PDT

I'm more worried that we'll spam the commit-queue's logs, or that we'll hang queues due to pipe full errors (but that should really already be handled by executive.py correctly). I suspect we may end up moving off of run_and_throw_if_fail here now that we don't need to watch the queue's live anymore.

Eric Seidel (no email)

Comment 4 2010-10-22 17:41:27 PDT

Committed r70374: <http://trac.webkit.org/changeset/70374>

Note You need to log in before you can comment on or make changes to this bug.