Summary: | Implement copyTextureToParentTextureCHROMIUM in WebGraphicsContext3DDefaultImpl. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephen White <senorblanco> | ||||||||
Component: | New Bugs | Assignee: | Stephen White <senorblanco> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | dglazkov, eric, jamesr, kbr, vangelis, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Other | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Stephen White
2010-10-22 13:56:30 PDT
Created attachment 71593 [details]
Patch
Attachment 71593 [details] did not build on chromium: Build output: http://queues.webkit.org/results/4708053 Attachment 71593 [details] did not build on chromium: Build output: http://queues.webkit.org/results/4624071 Created attachment 71747 [details]
Patch
Fix for warning-as-error on chromium/linux, and add chromium DEPS roll to pick up new API. Comment on attachment 71747 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71747&action=review This basically looks good but one issue. > WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:580 > + glGetTexLevelParameteriv(GL_TEXTURE_2D, 0, GL_TEXTURE_WIDTH, &width); Please guard this call either with a call to gfx::GetGLImplementation() (app/gfx/gl/gl_implementation.h) or a test of whether glGetTexLevelParameteriv is NULL. Actually, in the current structure, supportsCopyTextureToParentTextureCHROMIUM should return false if this function is not available. This should prevent crashes when running on ANGLE or a pure GLES2 implementation. See https://bugs.webkit.org/show_bug.cgi?id=48282 . Created attachment 71902 [details]
Patch
Comment on attachment 71902 [details]
Patch
Looks good.
Committed r70552: <http://trac.webkit.org/changeset/70552> *** Bug 47289 has been marked as a duplicate of this bug. *** |